Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Keychron Q4 #21996

Merged
merged 11 commits into from
Oct 5, 2023
Merged

Update Keychron Q4 #21996

merged 11 commits into from
Oct 5, 2023

Conversation

adophoxia
Copy link
Contributor

Description

Superseeds #21406, but this will only cover one board from each series update of PRs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 13, 2023
@dunk2k
Copy link
Contributor

dunk2k commented Sep 20, 2023

for q4/ansi, is there a default of either v1 or v2?

@adophoxia
Copy link
Contributor Author

for q4/ansi, is there a default of either v1 or v2?

Can you elaborate more on that?

@drashna
Copy link
Member

drashna commented Sep 21, 2023

for q4/ansi, is there a default of either v1 or v2?

No need. It uses the parent folder's keymaps, if they exist. As long as the layout macro is correct and supported, it will compile using those higher level keymaps. You can see this in the QMK CI logs, actually.

Also, diff makes it look... wonky.

@drashna drashna requested a review from a team September 21, 2023 05:08
drashna
drashna reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an entry to data/mapping/keyboard_aliases.hjson for the name change (since the old name won't compile on the new version)

@github-actions github-actions bot added the dd Data Driven Changes label Oct 5, 2023
@drashna drashna merged commit a7406a4 into qmk:develop Oct 5, 2023
3 checks passed
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@adophoxia @mechlovin
Update Keychron Q4 (qmk#21996)
9bbd29c
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@adophoxia @christrotter
Update Keychron Q4 (qmk#21996)
8603631
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@adophoxia @zgagnon
Update Keychron Q4 (qmk#21996)
89924b1
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@adophoxia
Update Keychron Q4 (qmk#21996)
5fa0267
mute-civilian pushed a commit to mute-civilian/qmk_firmware that referenced this pull request Feb 17, 2024
@adophoxia
Update Keychron Q4 (qmk#21996)
9239b6b
@adophoxia adophoxia mentioned this pull request Jun 9, 2024
Merged
14 tasks
@adophoxia adophoxia deleted the keychron-q4-update branch June 27, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
dd Data Driven Changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adophoxia @dunk2k @drashna @fauxpark